Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom rule not correctly reported as such #458

Open
fkohrt opened this issue Aug 21, 2024 · 0 comments
Open

Custom rule not correctly reported as such #458

fkohrt opened this issue Aug 21, 2024 · 0 comments

Comments

@fkohrt
Copy link
Contributor

fkohrt commented Aug 21, 2024

Describe the bug

Custom rules are not reported as such.

To Reproduce

Apply #457 or run the following to get around #456:

f <- report:::.report_effectsize_ttest
body(f)[[6]] <- quote(dot_args$rules <- if(is.null(dot_args$rules)) rules else dot_args$rules)
assignInNamespace(x = ".report_effectsize_ttest", value = f, ns = "report")

Now one can see that a custom rule...

t.test(formula = extra ~ group, data = sleep) |>
  report::report(rules = effectsize::rules(1, c("tiny", "yeah okay"), name = "Unknown"))

...is not correctly reported:

Effect sizes were labelled following  recommendations.

The Welch Two Sample t-test testing the difference of extra by group (mean in group 1 = 0.75, mean in group 2
= 2.33) suggests that the effect is negative, statistically not significant, and tiny (difference = -1.58,
95% CI [-3.37, 0.21], t(17.78) = -1.86, p = 0.079; Cohen's d = -0.88, 95% CI [-1.84, 0.10])

Expected behaviour

text <- paste0("Effect sizes were labelled following a custom set of rules.")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant