Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect warning with old ggplot2/failure to load see #692

Open
bbolker opened this issue Mar 2, 2024 · 2 comments
Open

incorrect warning with old ggplot2/failure to load see #692

bbolker opened this issue Mar 2, 2024 · 2 comments
Labels
Docs 📚 Something to be adressed in docs and/or vignettes

Comments

@bbolker
Copy link

bbolker commented Mar 2, 2024

In dealing with the ggplot2 version 3.5 mess (see #691), I accidentally reverted to version 3.4.0 instead of 3.4.4. If I then library("see") directly I get

> library(see)
Error: package or namespace load failed for ‘see’ in loadNamespace(i, c(lib.loc, .libPaths()), versionCheck = vI[[i]]):
 namespace ‘ggplot2’ 3.4.0 is being loaded, but >= 3.4.4 is required

but if I run performance::check_model(), it encounters the failure and assumes that the cause is that I don't have see installed.

performance::check_model(g1)
Package `see` required for model diagnostic plots.
Would you like to install it? [y/n] 

it then re-installs, fails to show the plot (as expected), and returns the raw object.

@strengejacke
Copy link
Member

So the correct warning would be in this case: could not load package see?

@bbolker
Copy link
Author

bbolker commented Mar 3, 2024

Yes. Ideally it would be good to pass through some information about the error.

@strengejacke strengejacke added the Docs 📚 Something to be adressed in docs and/or vignettes label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs 📚 Something to be adressed in docs and/or vignettes
Projects
None yet
Development

No branches or pull requests

2 participants