-
Couldn't load subscription status.
- Fork 215
Description
I just noticed that the SciPy-bundle module generated by --module-only is missing some paths.
Those are supposed to be added by the numpy extension. However the current mechanism is flawed:
- The result of
ext.run()is collected in a variable:easybuild-framework/easybuild/framework/easyblock.py
Lines 1950 to 1952 in bf0af10
txt = ext.run() if txt: self.module_extra_extensions += txt - This is then added to the module
lines = [self.module_extra_extensions]
The problems with this are:
- For
--module-onlythis is not run - For
--skipit might not be run - For
--parallel-extensionit is not used either:ext.postrun()
From our "official" easyblocks only numpy uses that mechanism.
So we need a new method for extensions that returns the module-extra when used as an extension. The current make_module_extra cannot be used for that.
I'd propose make_module_extra_extension but we already have make_module_extra_extensions which would be confusing.