Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SetFromVectorField and SetFromSTVectorField #359

Open
shishiousan opened this issue Dec 27, 2023 · 0 comments
Open

Improve SetFromVectorField and SetFromSTVectorField #359

shishiousan opened this issue Dec 27, 2023 · 0 comments
Assignees
Labels
field node-field wishlist Tell us which feature do you want in easifemClasses
Milestone

Comments

@shishiousan
Copy link
Member

SetFromVectorField and SetFromSTVectorField in STVector- and VectorField classes, respectively, can be improved.

Problematic parts are following
in SetFromVectorField (from 437)

SELECT TYPE (VALUE)
CLASS is (VectorField_)
  tnodes = obj%domain%GetTotalNodes()
  DO ii = 1, tnodes
    CALL VALUE%Get(VALUE=small_value, globalNode=ii)
    DO jj = 1, obj%spaceCompo
      CALL obj%Set(VALUE=small_value(jj), globalNode=ii, scale=scale,  &
        & addContribution=addContribution, timeCompo=timeCompo,  &
        & spaceCompo=jj)
    END DO
  END DO

and in SetFromSTVectorField (from 629)

SELECT TYPE (VALUE)
CLASS is (STVectorField_)
  tnodes = obj%domain%GetTotalNodes()
  DO ii = 1, tnodes
    CALL VALUE%Get(VALUE=small_value, globalNode=ii, timeCompo=timeCompo)
    CALL obj%Set(VALUE=small_value, globalNode=ii, scale=scale,  &
    & addContribution=addContribution)
  END DO
@shishiousan shishiousan added wishlist Tell us which feature do you want in easifemClasses node-field labels Dec 27, 2023
@shishiousan shishiousan added this to the v23.10.2 milestone Dec 27, 2023
@vickysharma0812 vickysharma0812 pinned this issue Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field node-field wishlist Tell us which feature do you want in easifemClasses
Projects
None yet
Development

No branches or pull requests

2 participants