Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM: fields "category" and "type" importable? #22

Open
wetterfrosch opened this issue Jan 24, 2020 · 1 comment
Open

OSM: fields "category" and "type" importable? #22

wetterfrosch opened this issue Jan 24, 2020 · 1 comment

Comments

@wetterfrosch
Copy link
Collaborator

wetterfrosch commented Jan 24, 2020

When looking at a nominatim sample response I am keen to key:value pairs like "category":"highway" and "type":"motorway". Seems like line 44 in geo.py would that be the place to add this, but would be already enough?

Of course the intended interpretation (stations close to high-traffic roads) of these results could be easily misleading; maybe a high traffic-road is just at the junction of two roads (or the sensor is behind a big building).

@wetterfrosch wetterfrosch changed the title OSM: Other field "category" and "type" importable? OSM: fields "category" and "type" importable? Jan 24, 2020
@amotl
Copy link
Member

amotl commented Jan 27, 2020

Thanks for suggesting that.

It looks like these fields

category: "highway"
type: "motorway"

are only available when using the jsonv2 request format for Nominatim, see


However, the geopy package obviously uses the json request format only, see
https://github.com/geopy/geopy/blob/1.20.0/geopy/geocoders/osm.py#L435-L439


I've just asked within geopy/geopy#305 (comment) if there would be a chance to extend that package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants