Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golden_toolkit] Golden tests are failing after upgrading Flutter SDK to v3.19.4 because fonts are allocating slightly more space #190

Open
yasinarik-talabat opened this issue Apr 1, 2024 · 3 comments

Comments

@yasinarik-talabat
Copy link

Description of the Problem:

  • Golden tests are failing after upgrading Flutter SDK to v3.19.4 because fonts are allocating slightly more space.
  • As you can see in the diff image below, since the new fonts are taking more vertical space (height seems to be changed), everything misaligned vertically. Since this is a list of texts, the misalignment is staggered (cumulative), adding the one above and so on.
Screenshot 2024-04-01 at 11 19 28 AM

How to resolve this issue?

@yasinarik-talabat yasinarik-talabat changed the title Golden tests are failing after upgrading Flutter SDK to v3.19.4 because fonts are allocating slightly more space [golden_toolkit] Golden tests are failing after upgrading Flutter SDK to v3.19.4 because fonts are allocating slightly more space Apr 1, 2024
@brennan-smith
Copy link

We're running into the exact same issue. Wondering if you found any workaround or if there was an update on this issue?

@ricardoboss
Copy link

Are you sure this is related to the toolkit and not Flutter increasing font rendering fidelity?

@brennan-smith
Copy link

If it was just due to Flutter increasing the fidelity I would expect to see similar things in my actual applications, but it's only occurring in the golden_toolkit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants