@NickalasB Should we append the name of the variant to the file name (my_file_name_android) for TargetPlatform.android? With the current state of the PR it just runs the test for all platforms but uses the same image every time

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:golden_toolkit/golden_toolkit.dart';
import 'package:sharezone/pages/settings/changelog_page.dart';

void main() {
  group(UpdatePromptCard, () {
    testGoldens(
      'display card as expected',
      (tester) async {
        await tester.pumpWidget(
          MaterialApp(
            home: Scaffold(
              body: Padding(
                padding: const EdgeInsets.all(8.0),
                child: Column(
                  children: [
                    UpdatePromptCard(),
                  ],
                ),
              ),
            ),
          ),
        );

        await screenMatchesGolden(tester, 'update_prompt_card');
      },
      variant: TargetPlatformVariant.all(),
    );
  });
}

@NickalasB Should we append the name of the variant to the file name (my_file_name_android) for TargetPlatform.android? With the current state of the PR it just runs the test for all platforms but uses the same image every time

import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:golden_toolkit/golden_toolkit.dart';
import 'package:sharezone/pages/settings/changelog_page.dart';

void main() {
  group(UpdatePromptCard, () {
    testGoldens(
      'display card as expected',
      (tester) async {
        await tester.pumpWidget(
          MaterialApp(
            home: Scaffold(
              body: Padding(
                padding: const EdgeInsets.all(8.0),
                child: Column(
                  children: [
                    UpdatePromptCard(),
                  ],
                ),
              ),
            ),
          ),
        );

        await screenMatchesGolden(tester, 'update_prompt_card');
      },
      variant: TargetPlatformVariant.all(),
    );
  });
}

I think in order for this to work you will need to modify the materialAppWrapper platform param.

As I understand it the TargetPlatformVariant sets the debugDefaultTargetPlatformOverride so maybe something like this...

WidgetWrapper materialAppWrapper({
  TargetPlatform? platform,
  Iterable<LocalizationsDelegate<dynamic>>? localizations,
  NavigatorObserver? navigatorObserver,
  Iterable<Locale>? localeOverrides,
  ThemeData? theme,
}) {
  return (child) => MaterialApp(
        localizationsDelegates: localizations,
        supportedLocales: localeOverrides ?? const [Locale('en')],
        theme: theme?.copyWith(
          platform:
              debugDefaultTargetPlatformOverride ?? TargetPlatform.android,
        ),...

@nilsreichardt also... for what you are trying to accomplish. Have you tried the multiScreenGolden function?

I have a card that shows different text for each platform (iOS, Android, Web, macOS). I created a golden test for that where I loop over the platforms. My goal with this PR is to make advantage of variant parameter so that I can remove the for loop. However, I'm uncertain if this change is actually good. I would tend to close this PR and suggest as a workaround to use just a for loop.

Here is the code of the test (and the golden files): https://github.com/SharezoneApp/sharezone-app/blob/main/app/test_goldens/pages/settings/changelog_page_test.dart

@nilsreichardt How about adding a test in your PR to assert that the desired behavior is working as intended, and then we can make the call as to whether it adds value? Thank you very much for helping to contribute!

How about adding a test in your PR to assert that the desired behavior is working as intended, and then we can make the call as to whether it adds value?

The way the PR is currently, does not work because I would need to change the file name for every variant (append the variant name as suffix). I'm going to close it for now.

How about adding a test in your PR to assert that the desired behavior is working as intended, and then we can make the call as to whether it adds value?

The way the PR is currently, does not work because I would need to change the file name for every variant (append the variant name as suffix). I'm going to close it for now.

@nilsreichardt No worries. Thank you for supporting and suggesting improvements!