Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for variant #179

Open
nilsreichardt opened this issue Aug 22, 2023 · 3 comments
Open

Add support for variant #179

nilsreichardt opened this issue Aug 22, 2023 · 3 comments

Comments

@nilsreichardt
Copy link
Contributor

The testWidgets method allows specifying variant parameter. This is helpful when you have different design for different platforms.

@NickalasB
Copy link
Contributor

HI @nilsreichardt. That doesn't seem like too crazy of a change. Would you be interested in opening up a PR to add the variant param to the testGoldens function?

@nilsreichardt
Copy link
Contributor Author

There is already an open PR. But the author seems to be inactive. Should I create a new PR or write a comment under the PR?

@NickalasB
Copy link
Contributor

Yeah I think making a new PR that is limited to just adding the variant param would be easiest honestly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants