Skip to content

Commit 16e56e1

Browse files
author
sheeplin
authored
refactor(user): remove cleaned_data (#275)
1 parent 349cd84 commit 16e56e1

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

hinghwa-dict-backend/user/view/manage.py

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,16 +95,13 @@ def put(self, request, id):
9595
info = body["user"]
9696
user_form = UserForm(info)
9797
user_info_form = UserInfoForm(info)
98-
user_info_form.cleaned_data.pop("user")
9998
if not user_form.is_valid or not user_info_form.is_valid:
10099
raise ValueError
101-
# forbid to change username
102-
user_form.cleaned_data.pop("username")
103-
# update fileds
104-
for key, value in user_form.cleaned_data.items():
105-
setattr(user, key, value)
106-
for key, value in user_info_form.cleaned_data.items():
107-
setattr(user.user_info, key, value)
100+
# update fields
101+
for key in ["password", "email"]:
102+
setattr(user, key, user_form[key])
103+
for key in user_info_form.fields:
104+
setattr(user.user_info, key, user_form[key])
108105
# special fields
109106
if "avatar" in info:
110107
user.user_info.avatar = uploadAvatar(user.id, info["avatar"])

0 commit comments

Comments
 (0)