Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux-x86-power-tools not building on musl #16

Open
aux-j opened this issue Jun 7, 2018 · 4 comments
Open

Linux-x86-power-tools not building on musl #16

aux-j opened this issue Jun 7, 2018 · 4 comments
Assignees

Comments

@aux-j
Copy link

aux-j commented Jun 7, 2018

Hi there,

Linux-x86-power-tools was not building on musl due to a missing include in turbostat.c - Here's a patch I've just whipped up to get it working:

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbostat/turbostat.c
index 5b1b807..055a514 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -30,6 +30,7 @@
#include <sys/stat.h>
#include <sys/resource.h>
#include <fcntl.h>
+#include <limits.h>
#include <signal.h>
#include <sys/time.h>
#include <stdlib.h>

@dywisor dywisor self-assigned this Jun 7, 2018
@leezu
Copy link

leezu commented Sep 8, 2018

You should propose this patch upstream in the linux kernel https://github.com/torvalds/linux/blob/master/tools/power/x86/turbostat/turbostat.c

@dywisor
Copy link
Owner

dywisor commented Sep 22, 2018

Sorry for catching this one late.

As @leezu suggested, please propose this patch upstream as it could also affect other packages relying on the same code base such as sys-apps/linux-misc-apps.

@aux-j
Copy link
Author

aux-j commented Dec 17, 2018

Hi @dywisor,

Sorry for the late reply, I'll submit a PR. Thanks!

@dywisor
Copy link
Owner

dywisor commented Mar 4, 2019

@gitlab-j Can you provide me with a link to the corresponding bug report for tracking purposes?

I'll include a patch in the next sys-power/linux-x86-power-tools ebuild, but eventually I'd like to see this fixed upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants