Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo App is resetted to the initial Version #80

Open
heckelmann opened this issue Aug 7, 2023 · 1 comment
Open

Demo App is resetted to the initial Version #80

heckelmann opened this issue Aug 7, 2023 · 1 comment

Comments

@heckelmann
Copy link
Collaborator

The current app.js (https://github.com/AloisReitbauer/progressiveDelivery-masterclass/blob/main/demoapp/app.js) is the minimal version of the app without Otel and FF.

Should we revert this commit (AloisReitbauer@4ff275a). I guess it was accidentally overwritten.

@agardnerIT
Copy link
Collaborator

This is the case because the documentation states that we built that as we go. So it made no sense to have OTEL and FFs pre-installed. So I removed it to match the documentation.

Now though, with the codespaces approach, it seems we're going for a "already-on" version on first install. So yes, I agree we need to revert to the "already instrumented" app version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants