Log partial success warnings (#45)

* Log partial success warnings

* Version and changelog

* Add test and fix condition

* Review comments

Author: dyladan

CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.7.2
+
+- Log response bodies when the response is `200` indicating the request was only partially accepted
+ 
 ## 0.7.1
 
 - Fix an error where max payload size was calculated using character count instead of bytes

lib/logstash/outputs/dynatrace.rb

@@ -160,6 +160,10 @@ def log_retryable_response(response)
         end
       end
 
+      def log_partial_success_response(response)
+        @logger.warn("Encountered partial success response", code: response.code, body: response.body)
+      end
+
       def log_error_response(response, ingest_endpoint_url, event)
         log_failure(
           "Encountered non-2xx HTTP code #{response.code}",
@@ -267,6 +271,8 @@ def send_event(event, attempt)
         response = client.post(ingest_endpoint_url, body: event, headers: headers)
 
         if response_success?(response)
+          # some events were not accepted but we don't know which ones or why
+          log_partial_success_response(response) if response_partial_success?(response)
           [:success, event, attempt]
         elsif retryable_response?(response)
           log_retryable_response(response)
@@ -315,6 +321,10 @@ def response_success?(response)
         response.code >= 200 && response.code <= 299
       end
 
+      def response_partial_success?(response)
+        response.code == 200
+      end
+
       def retryable_response?(response)
         RETRYABLE_CODES.include?(response.code)
       end

spec/outputs/dynatrace_spec.rb

@@ -168,6 +168,19 @@
       end
     end
 
+    context 'with partial success responses' do
+      let(:ingest_endpoint_url) { "http://localhost:#{port}/partial" }
+
+      before do
+        allow(subject).to receive(:log_partial_success_response)
+      end
+
+      it 'should warn on partial success' do
+        subject.multi_receive([event])
+        expect(subject).to have_received(:log_partial_success_response)
+      end
+    end
+
     context 'with retryable failing requests' do
       let(:ingest_endpoint_url) { "http://localhost:#{port}/retry" }
       let(:api_key) { 'placeholder-key' }

spec/spec_helper.rb

@@ -98,7 +98,12 @@ def self.retry_fail_count
 
   multiroute(%w[get post put patch delete], '/good') do
     self.class.last_request = request
-    [200, 'YUP']
+    [204, 'YUP']
+  end
+
+  multiroute(%w[get post put patch delete], '/partial') do
+    self.class.last_request = request
+    [200, 'partial success']
   end
 
   multiroute(%w[get post put patch delete], '/bad') do

version.yaml

@@ -1 +1 @@
-logstash-output-dynatrace: '0.7.1'
+logstash-output-dynatrace: '0.7.2'