Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlidePublishTask - handle ShowSlide and IsPublished() across versions #166

Open
jsirish opened this issue Apr 16, 2019 · 1 comment
Open
Labels

Comments

@jsirish
Copy link
Member

jsirish commented Apr 16, 2019

The SlidePublishTask was built to migrate from the original ShowSlide boolean to a versioned draft/live record. Now that ShowSlide has been dropped as a $db static, the task no longer works in recent versions.

We'll need to adjust the task across major versions to handle data migration from version 1 to 2, 2 to 3, and 3 to 4.

This may require a database query to see if the records contain the ShowSlide column in the version after this was depreciated.

@muskie9
Copy link
Member

muskie9 commented May 8, 2019

After discussion we'll focus on the following:

  • Remove the publish task from the 4 branch
  • Revisit the publish task in the 3 branch to ensure it is working as expected
  • Anything v2 or before would be done on a project to project basis and not covered anymore by the module support

@muskie9 muskie9 modified the milestones: 3.1.0, 4.0.0 May 8, 2019
muskie9 added a commit to muskie9/SilverStripe-FlexSlider that referenced this issue May 17, 2019
@muskie9 muskie9 removed the v4 label May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants