Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate ante handlers for Cosmos and EVM fees #29

Open
zale144 opened this issue Jun 6, 2024 · 0 comments · May be fixed by #30
Open

Separate ante handlers for Cosmos and EVM fees #29

zale144 opened this issue Jun 6, 2024 · 0 comments · May be fixed by #30
Assignees
@zale144

Comments

@zale144
Copy link

zale144 commented Jun 6, 2024

Currently the Feemarket parameters are applied to the cosmos based transactions through the MinGasPriceDecorator here

evmos/app/ante/handler_options.go

Line 119 in b2ef7a4

cosmosante.NewMinGasPriceDecorator(options.FeeMarketKeeper, options.EvmKeeper),
and here

evmos/app/ante/handler_options.go

Line 145 in b2ef7a4

cosmosante.NewMinGasPriceDecorator(options.FeeMarketKeeper, options.EvmKeeper),
.

But also through the DeductFeeDecorator, by using the DynamicFeeChecker here

evmos/app/app.go

Line 874 in 1a3b3f3

TxFeeChecker: ethante.NewDynamicFeeChecker(app.EvmKeeper),
.

The result is that the EVM-based gas fees are applied in the Cosmos transactions, where now we would like them to be segregated. So, have the EVM transactions be calculated based on the Feemarket parameters, and the Cosmos/validator gas fees based on the app settings found in `.../config/app.toml.
@zale144 zale144 self-assigned this Jun 6, 2024
@zale144 zale144 linked a pull request Jun 6, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zale144 zale144

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(ante): separate Cosmos from EVM fee ante handlers dymensionxyz/evmos
1 participant
@zale144