Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete validation for MsgRollappFraudProposal #1558

Open
omritoptix opened this issue Nov 26, 2024 · 0 comments
Open

Incomplete validation for MsgRollappFraudProposal #1558

omritoptix opened this issue Nov 26, 2024 · 0 comments
Assignees

Comments

@omritoptix
Copy link
Contributor

In x/rollapp/types/message_fraud_proposal.go:14-32, the ValidateBasic method of the MsgRollappFraudProposal is incomplete. It does not validate fields such as RollappId, RollappRevision, FraudHeight, and PunishSequencerAddress to ensure they are correctly set and valid.
Without these validations, an invalid fraud proposal could be accepted for voting, run the full proposal lifecycle, only to fail during execution. This creates inefficiencies and risks undermining the governance process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants