Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdk ibc: Consolidate canonical channel/port across hub genesis and hub modules #470

Open
danwt opened this issue Jun 25, 2024 · 1 comment
Assignees
Labels

Comments

@danwt
Copy link
Contributor

danwt commented Jun 25, 2024

see also #467

cc @zale144

@danwt danwt added the security label Aug 22, 2024
@danwt danwt changed the title Consolidate canonical channel/port across hub genesis and hub modules rdk ibc: Consolidate canonical channel/port across hub genesis and hub modules Aug 22, 2024
@danwt
Copy link
Contributor Author

danwt commented Aug 23, 2024

IIRC there was some canonical channel concept introduced on the rollapp when Alex and I did the genesis transfers and the denom metadata work,
These are old issues, but need to be done/double checked
I'm just looking now

func (s *State) IsCanonicalHubTransferChannel(port, channel string) bool {
return s.CanonicalHubTransferChannelHasBeenSet() && s.HubPortAndChannel.Port == port && s.HubPortAndChannel.Channel == channel
}

Yeah I think we need to write an upgrade on the rollapp to set canonical channel for existing rollapps

state.go
func (s *State) IsCanonicalHubTransferChannel(port, channel string) bool {
return s.CanonicalHubTransferChannelHasBeenSet() && s.HubPortAndChannel.Port == port && s.HubPortAndChannel.Channel == channel
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants