Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Bootstrap Grids Section #20

Closed
1 task done
Cleop opened this issue May 30, 2017 · 3 comments
Closed
1 task done

Create Bootstrap Grids Section #20

Cleop opened this issue May 30, 2017 · 3 comments
Assignees
@iteles
Labels
enhancement please-test priority-2 T1d
Milestone
Sprint 1

Comments

@Cleop
Copy link
Member

Cleop commented May 30, 2017 •
edited by katbow
Loading

@Cleop Cleop self-assigned this May 30, 2017
@Cleop Cleop changed the title Grids Section Create Bootstrap Grids Section May 30, 2017
@Cleop Cleop modified the milestone: Sprint 1 May 31, 2017
Cleop added a commit that referenced this issue May 31, 2017
@Cleop
Adds beginning of grid section, #20
a32e198
@Cleop Cleop mentioned this issue May 31, 2017
Closed
@katbow katbow assigned katbow and unassigned Cleop Jun 1, 2017
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Resolve merge conflict with gird #20
8aef3d1
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add grid html to components to be served #20
9a48cfb
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Finish stacked-to-horizontal section #20
a8b058e
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add section for mobile and desktop grid #20
016ac96
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add mobile, tablet & desktop grid section #20
a2484b0
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add section for column wrapping #20
42d224a
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Fix spacing between rows on mobile and desktop #20
c12e11f
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add section about responsive column resets #20
07cbb99
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add section for nesting content #20
fa645c6
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Differentiate between stacked and horizontal grids on mobile/desktop #20
7ed1db2
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add details on fluid vs fixed grid container #20
adb5f2f
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add test for getting each component #20
405cbd7
katbow added a commit that referenced this issue Jun 1, 2017
@katbow
Add component list with grid #20
17f6c83
@katbow
Copy link
Collaborator

katbow commented Jun 1, 2017 •
edited
Loading

The only section that's not complete for this is grid offsetting.

http://getbootstrap.com/css/#grid-offsetting

There are currently no percentage left (or right) margins in tachyons. The only other option would be to use fixed with columns and margins, however I didn't think this was a good alternative. Seems like a better one to leave for now and come back to at another time!

captured in #33 for future reference.

@katbow katbow mentioned this issue Jun 1, 2017
Merged
@katbow katbow removed the in-progress label Jun 1, 2017
@katbow
Copy link
Collaborator

katbow commented Jun 2, 2017

merged in minus the last section which is captured in a separate issue 👍

@katbow katbow closed this as completed Jun 2, 2017
@katbow katbow reopened this Jun 5, 2017
@katbow katbow assigned iteles and unassigned katbow Jun 5, 2017
@iteles
Copy link
Member

iteles commented Aug 10, 2017

LGTM 👍

@iteles iteles closed this as completed Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iteles iteles

Labels
enhancement please-test priority-2 T1d
Projects
None yet
Milestone
Sprint 1
Development

No branches or pull requests
3 participants
@katbow @iteles @Cleop