Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Adding concepts clarification and tutorial #2

Merged
merged 35 commits into from
Jan 12, 2023

Conversation

LuchoTurtle
Copy link
Member

closes #1

This PR should be the initial template for the project.
Has a section describing concepts for better understanding and a tutorial to follow through integration with Stripe.

@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. labels Dec 21, 2022
@LuchoTurtle LuchoTurtle self-assigned this Dec 21, 2022
README.md Outdated Show resolved Hide resolved
@LuchoTurtle
Copy link
Member Author

Even though it's still in progress, @nelsonic you can take a look at the "theory" part and check if there's anything big missing in it, before I start doing an example.
I didn't think going over the features of each alternative would be worthwhile from an engineering standpoint, as that is just marketing, imo.

@LuchoTurtle
Copy link
Member Author

Added Stripe integration. It should be fully working, with authentication and checkout sessions.
I still want to expand the example more, though. Even though this works, I still want to block user access of unpaid users. Still need to see how that can be implemented with Stripe's API 🤔

@nelsonic
Copy link
Member

Sounds good. keep going. looking forward to reading your research findings. 👌

mix.exs Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@LuchoTurtle
Copy link
Member Author

This should be done. I've added the project, used DETS for storage (no need for PostgreSQL here) and I got it running with 100% coverage.

Fixed some README typos and changed the Fork example you mentioned in the feedback.

I also added CI (but it didn't execute in this PR).

@LuchoTurtle LuchoTurtle added awaiting-review An issue or pull request that needs to be reviewed and removed in-progress An issue or pull request that is being worked on by the assigned person labels Dec 28, 2022
@LuchoTurtle LuchoTurtle removed their assignment Dec 28, 2022
@nelsonic nelsonic added in-review Issue or pull request that is currently being reviewed by the assigned person and removed awaiting-review An issue or pull request that needs to be reviewed labels Dec 30, 2022
@nelsonic
Copy link
Member

you-are-the-product

README.md Outdated
[That's a great question](https://www.indiehackers.com/post/stripe-vs-paddle-89161b0d5c).

[Which seems to asked](https://splitbee.io/blog/why-we-moved-from-stripe-to-paddle)
[over](https://stackshare.io/stackups/paddle-vs-stripe),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't do this. [over] and [over] and [over] is not good link text. dwyl/contributing#119
I understand that you are emphasising the fact that many people have had these same questions.
But as a document that we want to read, maintain and have others contribute to.
We want to set high standards for link text.
Please/thanks! 🙏

@nelsonic
Copy link
Member

nelsonic commented Jan 3, 2023

** (Mix) Expected one or more files/patterns to be given to mix format or for a .formatter.exs file to exist with an :inputs or :subdirectories key

https://github.com/dwyl/learn-payment-processing/actions/runs/3828017445/jobs/6513143646
image

@codecov
Copy link

codecov bot commented Jan 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@da457e4). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main        #2   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         9           
  Lines           ?        38           
  Branches        ?         0           
========================================
  Hits            ?        38           
  Misses          ?         0           
  Partials        ?         0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LuchoTurtle this write-up is superb. 😍 Well done. 🎉

@nelsonic nelsonic merged commit 3110b40 into main Jan 12, 2023
@nelsonic nelsonic deleted the initial-implementation branch January 12, 2023 11:59
@nelsonic
Copy link
Member

Note: I made a few tweaks but your core content is excellent. Keep up the great work. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or enhancement of existing functionality epic A feature idea that is large enough to require a sprint (5 days) or more and has smaller sub-issues. in-review Issue or pull request that is currently being reviewed by the assigned person
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Feat: Learn + Document How to Setup Recurring Payment Processing
2 participants