Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Adding way to add callback path in config files. #49

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

LuchoTurtle
Copy link
Member

addresses #39

Adds a way for people to config the callback path in their config files, instead of only through env variables.

@LuchoTurtle LuchoTurtle added enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person elixir Pull requests that update Elixir code labels Feb 8, 2024
@LuchoTurtle LuchoTurtle self-assigned this Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a934b1) 100.00% compared to head (2f31003) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #49   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           34        34           
=========================================
  Hits            34        34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuchoTurtle LuchoTurtle merged commit e996da3 into main Feb 8, 2024
3 checks passed
@LuchoTurtle LuchoTurtle deleted the callback_config#39 branch February 8, 2024 01:33
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition for people who prefer this config method. 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code enhancement New feature or enhancement of existing functionality in-progress An issue or pull request that is being worked on by the assigned person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants