Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Leak Issue #38

Open
markworden opened this issue Dec 30, 2015 · 1 comment
Open

Memory Leak Issue #38

markworden opened this issue Dec 30, 2015 · 1 comment

Comments

@markworden
Copy link

Hi great job on this slider. It is very useful. I wanted to report an issue though where there is a memory leak that I believe is related to not unbinding the mousedown and mouseup events in the onRemove. I happen to be creating a removing the old slider control and creating a new slider control when my data is updated, and I saw the memory usage increasing. Using the Chrome dev tools, I found that it was related to the slider control. I made an update to the code to unbind the listeners in the onRemove, and the memory leak has gone away. If you want me to send you my version of the code, please let me know.

@dwilhelm89
Copy link
Owner

Thanks. Could you provide your changes as a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants