Skip to content
This repository has been archived by the owner on Aug 9, 2022. It is now read-only.

Creating element without label #54

Open
garethferguson opened this issue May 24, 2016 · 6 comments
Open

Creating element without label #54

garethferguson opened this issue May 24, 2016 · 6 comments

Comments

@garethferguson
Copy link

Is it possible to create a text element without a label? I've tried setting the value to null and '' but the label is still created.

BootForm::text('amount', null, '14.50);

@dwightwatson
Copy link
Owner

Yeah - the package tries to be smart and sort out a label for you. Not a bad idea to have an option to create an input without an input. Happy to take a look at any PRs that implement this.

@georgearnall
Copy link
Contributor

I would like to look into this, I've setup the repo how are we supposed to test it?
I don't quite understand the workflow for developing laravel packages.

@dwightwatson
Copy link
Owner

composer install on the repo and you'll be able to use PHPUnit to run the test suite. If you want to test inside a Laravel app you can define the location of the package using a local URL so you can test with your clone.

@georgearnall
Copy link
Contributor

georgearnall commented Oct 22, 2016

Thanks, no tests for fields (only open/close forms) ?

@dwightwatson
Copy link
Owner

Looks like it, the test suite can do with some work, I never got around to implementing it completely.

@georgearnall
Copy link
Contributor

georgearnall commented Oct 23, 2016

Ok, well I've sent a pull request with no label options for you to take a look at.

#67

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants