Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: copy instances/endpoints info while updating mainsail/fluidd #463

Open
szafran81 opened this issue May 2, 2024 · 2 comments
Open
Labels
✨ feature request New feature or request
Milestone

Comments

@szafran81
Copy link

Is your feature request related to a problem? Please describe

Right now every update removes instances/endpoints configuration from config.json in both mainsail and fluidd.

Describe the solution you'd like

While updating read and copy to new config the instances configuration:

In mainsail (config.json):

    "instancesDB": "json",
    "instances": [
        { "hostname": "192.168.1.99", "port": 7125 },
        { "hostname": "192.168.1.99", "port": 7126 }
    ]

In fluidd (config.json):

  "endpoints": [
    "http://192.168.1.99:7125",
    "http://192.168.1.99:7126"
  ],

And I think there is a lot more info that can be copied with that.
Maybe walking through the config and only copying from new config.json data that's been added and leaving old settings untouched?

Describe alternatives you've considered

Reconfiguring by manually editing config files after every update is such a waste of time.

Additional information

No response

@dw-0 dw-0 changed the title Copy instances/endpoints info while updating mainsail/fluidd feat: copy instances/endpoints info while updating mainsail/fluidd May 2, 2024
@dw-0 dw-0 added the ✨ feature request New feature or request label May 2, 2024
@dw-0 dw-0 added this to the next milestone May 2, 2024
@dw-0
Copy link
Owner

dw-0 commented May 2, 2024

Thanks for the request. I added it to the backlog. It will not be implemented in the current v5 of KIAUH. I consider to implement it in v6, as the migration from bash to python will drastically help in that regard.

@szafran81
Copy link
Author

That's great. Thank you for taking it into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants