New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deflate compression allocates max buffer size for every operation #258

Open

CrspyAu opened this issue Nov 28, 2024 · 1 comment

CrspyAu commented Nov 28, 2024

Setting the maxBufferSizeBytes to handle the largest expected operation also allocates that memory for the smallest.

It would be good if the buffer could expand up to the max, rather than be pre-allocated.

Re: #238

Owner

dvsekhvalnov commented Nov 28, 2024

Hi @CrspyAu , i guess good point.

Probably doable via extending MemoryStream and overriding Capacity property: https://github.com/dotnet/runtime/blob/1d1bf92fcf43aa6981804dc53c5174445069c9e4/src/libraries/System.Private.CoreLib/src/System/IO/MemoryStream.cs#L252

wanna provide proof of concept PR?

CrspyAu mentioned this issue

Capped buffer expansion #259

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment