-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working? #1
Comments
Hi @dehy! That's strange – this tool is being used on a daily basis on one of my projects. I noticed that your ffprobe is complaining about stream 1, not stream 0 (where ID3 is). What do you have on stream1? Can you do ffmpeg -i on your source file, before metadata injection? |
Having issues as well. Looks like everything is working but the id3 tags aren't being thrown by Flash or an HTML5 player. The third stream 'timed_id3' gets added after I use your program. It's also on a working segment that is throwing the event right. Input #0, mpegts, from 'fubo-test-000.ts': |
@pcouture what Flash player do you use? I've personally tested this (and using on a daily basis) with flashls and iOS native video player. As for the native HTML5 streaming in browsers - I'm not sure if any browser supports metadata yet (when I developed this, I had no choice but to use a Flash player) |
Hey Dusterio, Thank you for responding. I'm using JWPlayer to try to get the cues because I have it working using Wowza but now I'm trying to do a Kurento RTP stream to ffmpeg HLS output, then I use your script to encode the ID3's. I'm not 100% if I'm encoding the stream right. It plays fine in JWPlayer, HLS.js but not VLC or Safari. Not very senior with ffmpeg. Do you have any experience with a ffmpeg hls stream with this? I've pasted the encoder settings below if so. p.s. I've been going through forums all week and its like I"m following your trail a year ago. Flashhls is the one that stands out lol. Cheers,
|
Hey Hi, But how are you inserting the ID# tags in video. Using what command On Fri, Mar 25, 2016 at 10:27 AM, Peter Couture [email protected]
|
After running this tool on a segment, Getting this error https://github.com/bjarnoldus/momovi-video-hls/blob/master/flash/src/org/mangui/HLS/muxing/PES.as#L66 in flashhls based webplayers This is the exact error "PES start code not found or not AAC/AVC: 269" This is the before output from ffmpeg
and after output from ffmpeg
|
Hmm, I'm not 100% sure but it looks like that player only allows video or audio streams - no metadata streams. See lines 64 and 65. I'm personally using this one: https://github.com/mangui/flashls, as well as native iOS player - both play my videos with ID3 metadata just fine. I'm concerned about your ffmpeg output though - I will check further about it. ffmpeg shouldn't give any warnings |
@dusterio The above coderef i have shared is for the flashls only. The above problem is reproduced on flashls build Here is what i am using for id3 injection. Metadata file contents
Script output
Once above tag is injected into a .ts file, flashls just stalls. (I can play the id3 injected video in mplayer though). In order to test the metadata presence i am using flashls. So far did not had any luck with both (your code & flashls). Not sure which one to check. I just had one question. Is the time thats specified in the metadata file, relative to the current segment or relative to the entire stream ?. An example in your README should help ! |
Relative to the segment file you are passing! I, for instance, cut the video in 10 second segments and always inject at 0 seconds - so each of segments has a text in the beginning |
@dusterio Thank You. I have tried |
@nareshv good to know! I'm surprised that flashls.org still contains links to the old version, they fixed this a year ago! |
One new thing. I am not able to inject the metadata into a segment thats generated using ffmpeg command. Could you help me with this ? Generate dummy video with ffmpeg
Inject the timing
Output of new file from ffmpeg (no id3 tag inserted, but the new stream 0:2 is visible)
ffmpeg version is 2.8 |
I'm seeing the same problem mentioned above where metadata is not being injected into .ts files created with FFMPEG. It looks as though this might be because no PTS (presentation timestamps) are being discovered. Any idea why this might be? Is this because FFMPEG is not inserting the optional PES header? https://github.com/dusterio/hlsinjector/blob/master/injector.php#L231 |
Dear @byrion, it has been some time. but where you able to solve this? |
@BoydRotgans , @byrion , This will code will work with ffmpeg versions up to ffmpeg-4.2.2 https://www.johnvansickle.com/ffmpeg/old-releases/ffmpeg-4.2.2-amd64-static.tar.xz Versions higher that this fail. If someone could isolate the ffmpeg pull request that broke this code it could be updated to work with newer versions of ffmpeg. |
Hi there ! Thank you for this greate lib but I can't make it work...
I inject id3 into each .ts segments i have, at 0 seconds. ffprobe and mediastreamvalidator show me a timed id3 "track" but it's not triggered in my code.
I've tested my playing code with Apple stream samples and it triggers the timedmetadata notification well.
The text was updated successfully, but these errors were encountered: