fix: Made style switching buttons work again

Author: dusktreader

CHANGELOG.md

@@ -5,6 +5,9 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## v5.4.1 - 2025-03-14
+* Fixed style switching buttons
+
 ## v5.4.0 - 2025-03-14
 * Added position label
 * Added summary text for staff & senior engineer positions

pyproject.toml

@@ -1,6 +1,6 @@
 [project]
 name = "cv"
-version = "5.4.0"
+version = "5.4.1"
 description = "Tools for building career documents."
 readme = "README.md"
 requires-python = ">=3.13"

src/app/constants.py

@@ -23,7 +23,7 @@ def emoji(cls) -> str:
         pass
 
     def js(self) -> str:
-        return f"replaceStyle({self}, {self.label()})"
+        return f"replaceStyle('{self}', '{self.label()}')"
 
 
 class ColorScheme(HtmlChoices):
@@ -63,9 +63,6 @@ def label(cls) -> str:
     def emoji(cls) -> str:
         return "🔍"
 
-    def js(self) -> str:
-        return f"replaceStyle({self}, {self.label()})"
-
 
 class Position(HtmlChoices):
     manager = auto()

static/js/switchers.js

@@ -11,18 +11,21 @@ const titles = {
     }
 }
 
-window.onload = () => {
+const getSummary = () => {
   var sumElement = document.getElementById("summary")
   children = sumElement.children
+  var summary = "<i>Couldn't find default summary!<i>"
   Array.from(children).forEach((child) => {
     if (child.tagName === "P") {
       text = child.innerHTML
-      console.log("Setting default summary")
-      localStorage.setItem("defaultSummary", child.innerHTML)
+      console.log("Found and saved default summary")
+      summary = child.innerHTML
     }
   });
+  return summary
 }
 
+const defaultSummary = getSummary();
 const head = document.getElementsByTagName('head')[0];
 
 const replaceStyle = (name, label) => {
@@ -48,11 +51,7 @@ const changePosition = (key) => {
   var summaryText = titles[key].summary
   if (!summaryText) {
     console.log("Using default summary")
-    summaryText = localStorage.getItem("defaultSummary");
-  }
-  if (!summaryText) {
-    console.log("No default summary found")
-    summaryText = "<i>Couldn't load default summary from local storage. Please refresh page<i>"
+    summaryText = defaultSummary;
   }
   posElement.innerHTML = titles[key].position
   sumElement.innerHTML = `<p>${summaryText}</p>`