Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web-wallet: Warn Users About Sending Funds to Their Own Account in Send Flow #3099

Closed
nortonandreev opened this issue Nov 30, 2024 · 0 comments · Fixed by #3105
Closed

web-wallet: Warn Users About Sending Funds to Their Own Account in Send Flow #3099

nortonandreev opened this issue Nov 30, 2024 · 0 comments · Fixed by #3105
Assignees
Labels
module:web-wallet Issues related to web-wallet module type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@nortonandreev
Copy link
Contributor

Description

Following rusk issue #2959, we need to implement similar functionality in the Web Wallet. Specifically, in the Send flow, if a user attempts to send funds to their own account's moonlight address, the following should occur:

  • Display a warning message informing the user that gas will be deducted for such a transaction.
  • Optionally, provide an opportunity to redirect the user to the Allocate flow. However, as this does not avoid gas fees, its utility may be limited.

Scope of Work

  • Warning Message: Add a clear warning when users attempt to send funds to their own moonlight address. The message should explain that gas fees will still apply.
  • Optional Redirect: Consider adding an option to redirect users to the Allocate flow. Clearly explain the implications, i.e., that this will not avoid gas fees.
  • Validation Logic: Update the Send flow to include a check for self-referential transactions involving moonlight addresses.

User Experience Goals

  • Prevent confusion or unintended behavior when users send funds to their own account.
  • Clearly inform users about gas fees associated with such transactions.

Tasks

  1. Identify where in the Send flow validation the moonlight address check should be implemented.
  2. Display a warning message if the destination address matches the user's own moonlight address.
  3. Optionally, implement a redirection to the Allocate flow, ensuring users understand its implications.
  4. Test thoroughly to ensure correct behavior and no regressions.
@nortonandreev nortonandreev added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:web-wallet Issues related to web-wallet module labels Nov 30, 2024
@nortonandreev nortonandreev self-assigned this Dec 2, 2024
@nortonandreev nortonandreev changed the title web-wallet: Warn Users About Sending Funds to Their Own Moonlight Address in Send Flow web-wallet: Warn Users About Sending Funds to Their Own Account in Send Flow Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:web-wallet Issues related to web-wallet module type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant