Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Rusk Versioning #2197

Closed
fed-franz opened this issue Aug 23, 2024 · 3 comments · Fixed by #2251
Closed

Introduce Rusk Versioning #2197

fed-franz opened this issue Aug 23, 2024 · 3 comments · Fixed by #2251
Assignees
Labels
module:consensus Issues related to consensus module module:node Issues related to node module type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)

Comments

@fed-franz
Copy link
Contributor

Summary

To properly enable a network, where nodes can have different versions of the node, we need to integrate a version labeling system which entails both releasing binaries tied to a specific commit (see tags) and handling data and peers using older (or newer) versions of the protocol.

Also see dusk-network/dips#6

@fed-franz fed-franz added type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc) module:consensus Issues related to consensus module module:node Issues related to node module labels Aug 23, 2024
@autholykos
Copy link
Member

This is pretty important to have so that we can manage versions and avoid unduly slashing caused by invalid blocks that are simply following an older version of the protocol.

@fed-franz
Copy link
Contributor Author

The main thing to introduce is a Version field in the Consensus messages

@fed-franz
Copy link
Contributor Author

Also we should release the protocol as version 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:consensus Issues related to consensus module module:node Issues related to node module type:enhancement Issues concerning code or feature improvement (performance, refactoring, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants