New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added serde support #30

Open

d-sonuga wants to merge 1 commit into main from add-serde-feature

+456 −2

d-sonuga commented Dec 5, 2024 •

edited

Loading

For dusk-network/rusk/issues/2773 and #29.

d-sonuga force-pushed the add-serde-feature branch from 6b6d958 to 035db06 Compare

December 5, 2024 15:13

HDauven requested review from moCello and Neotamandua

December 6, 2024 11:43

Neotamandua reviewed

View reviewed changes

Member

Neotamandua left a comment

Looks good in general. I also added a suggestion, but we can wait for another maintainer's opinion before applying it.

src/serde_support.rs Outdated Show resolved Hide resolved

Neotamandua requested a review from miloszm

December 6, 2024 14:54

moCello reviewed

View reviewed changes

src/serde_support.rs Outdated Show resolved Hide resolved

moCello reviewed

View reviewed changes

tests/serde.rs Outdated Show resolved Hide resolved

d-sonuga force-pushed the add-serde-feature branch from 035db06 to fbcb957 Compare

December 9, 2024 07:45

moCello reviewed

View reviewed changes

src/serde_support.rs Outdated Show resolved Hide resolved

moCello reviewed

View reviewed changes

src/serde_support.rs Outdated Show resolved Hide resolved

d-sonuga force-pushed the add-serde-feature branch 2 times, most recently from f2b763d to dc628c3 Compare

December 9, 2024 10:27

moCello reviewed

View reviewed changes

src/serde_support.rs Outdated Show resolved Hide resolved

d-sonuga force-pushed the add-serde-feature branch 2 times, most recently from ba2a394 to 0b2a7ad Compare

December 9, 2024 21:57

moCello reviewed

View reviewed changes

src/serde_support.rs Show resolved Hide resolved

moCello approved these changes

View reviewed changes

Member

moCello left a comment

LGTM.
If you want you could also add some tests for failing serialization but that's not blocking.

d-sonuga force-pushed the add-serde-feature branch from 0b2a7ad to 1f3119e Compare

December 10, 2024 12:49

Neotamandua self-requested a review

December 10, 2024 12:52

Neotamandua approved these changes

View reviewed changes

Member

Neotamandua left a comment

LGTM. It would be nice if you would check the other PRs now and adjust them for any suggestions that apply to them as well, like the failed tests we talked about and the general structure we have here now.

d-sonuga force-pushed the add-serde-feature branch 2 times, most recently from 30a209e to 5bbe558 Compare

December 10, 2024 13:03

Neotamandua mentioned this pull request

Add serde feature dusk-network/jubjub#141

Merged

moCello reviewed

View reviewed changes

Member

moCello left a comment

Please also add an entry to the changelog


          Added serde support

bc1d0d5

d-sonuga force-pushed the add-serde-feature branch from 5bbe558 to bc1d0d5 Compare

December 11, 2024 15:04

d-sonuga requested a review from moCello

December 11, 2024 15:12

moCello approved these changes

View reviewed changes

Neotamandua linked an issue

that may be closed by this pull request

Add serde support #29

Open

moCello mentioned this pull request

Add serde feature to our stack dusk-network/rusk#2773

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet