From 2bb27b28fceabe5c4182888699d31164ced470d6 Mon Sep 17 00:00:00 2001 From: duongminhhieu Date: Fri, 7 Jun 2024 09:37:07 +0700 Subject: [PATCH 1/2] refactor: validation + throw exception --- .../common/configs/security/SecurityConfiguration.java | 1 + .../yasminishop/product/dto/request/ProductRequest.java | 2 ++ .../com/learning/yasminishop/yasminiai/YasMiniAIService.java | 2 +- 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java b/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java index d2668fe..0076098 100644 --- a/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java +++ b/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java @@ -41,6 +41,7 @@ public class SecurityConfiguration { }; private static final String[] ALLOWED_ORIGINS = { + "http://10.200.2.95:3000", "http://localhost:5173", }; diff --git a/src/main/java/com/learning/yasminishop/product/dto/request/ProductRequest.java b/src/main/java/com/learning/yasminishop/product/dto/request/ProductRequest.java index 45abcef..b428ad0 100644 --- a/src/main/java/com/learning/yasminishop/product/dto/request/ProductRequest.java +++ b/src/main/java/com/learning/yasminishop/product/dto/request/ProductRequest.java @@ -2,6 +2,7 @@ import com.learning.yasminishop.common.validator.FieldNotEmpty.FieldNotEmptyConstraint; import com.learning.yasminishop.common.validator.FieldNotNull.FieldNotNullConstraint; +import jakarta.validation.constraints.Min; import lombok.*; import lombok.experimental.FieldDefaults; @@ -40,6 +41,7 @@ public class ProductRequest { @FieldNotNullConstraint(field = "quantity", message = "FIELD_NOT_NULL") @FieldNotEmptyConstraint(field = "quantity", message = "FIELD_NOT_EMPTY") + @Min(value = 1, message = "INVALID_QUANTITY") Long quantity; @FieldNotNullConstraint(field = "isAvailable", message = "FIELD_NOT_NULL") diff --git a/src/main/java/com/learning/yasminishop/yasminiai/YasMiniAIService.java b/src/main/java/com/learning/yasminishop/yasminiai/YasMiniAIService.java index 71689d8..472726b 100644 --- a/src/main/java/com/learning/yasminishop/yasminiai/YasMiniAIService.java +++ b/src/main/java/com/learning/yasminishop/yasminiai/YasMiniAIService.java @@ -91,7 +91,7 @@ public List findCarByImage(MultipartFile file){ } catch (Exception e) { log.error("Error finding car by image", e); - throw new AppException(ErrorCode.GENERATIVE_AI_ERROR); + return List.of(); } } From e4e708a264911401f8745480fdd9a06c4b8cec51 Mon Sep 17 00:00:00 2001 From: duongminhhieu Date: Sat, 8 Jun 2024 13:50:16 +0700 Subject: [PATCH 2/2] refactor: refactor something --- .../common/configs/security/SecurityConfiguration.java | 3 +-- src/main/resources/application.yml | 1 + 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java b/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java index 0076098..86bf687 100644 --- a/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java +++ b/src/main/java/com/learning/yasminishop/common/configs/security/SecurityConfiguration.java @@ -29,7 +29,7 @@ public class SecurityConfiguration { "/swagger-ui/**", "/api-docs/**", "/categories", - "/categories/{slug}", + "/categories/slug/{slug}", "/products", "/products/{slug}", "/rating", @@ -41,7 +41,6 @@ public class SecurityConfiguration { }; private static final String[] ALLOWED_ORIGINS = { - "http://10.200.2.95:3000", "http://localhost:5173", }; diff --git a/src/main/resources/application.yml b/src/main/resources/application.yml index e5bf125..a97dd3c 100644 --- a/src/main/resources/application.yml +++ b/src/main/resources/application.yml @@ -14,6 +14,7 @@ server: port: 8080 servlet: context-path: /api/v1 + # address: 0.0.0.0 application: jwt: