Fix favicon on dune docs #929
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| <path d="M44.632 18.6539C69.1237 8.50919 97.2022 20.1397 107.347 44.6313C108.936 48.4675 109.991 52.3919 110.545 56.3214L24.6588 91.8968C22.2725 88.7259 20.2436 85.2051 18.6546 81.3689C8.50984 56.8772 20.1403 28.7987 44.632 18.6539Z" fill="#171717"/> | ||
| <svg width="1200" height="1200" viewBox="0 0 1200 1200" fill="none" xmlns="http://www.w3.org/2000/svg"> | ||
| <g clip-path="url(#clip0_21524_4673)"> | ||
| <rect width="1200" height="1200" fill="white"/> |
There was a problem hiding this comment.
Bug: Favicon Transparency Fix Incomplete
The white background rectangle remains in the new favicon SVG, which contradicts the PR's goal of fixing the favicon to have a transparent background like the one on dune.com. The fill="white" attribute causes the same white background issue the PR intended to resolve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm noticing the favicon on docs.dune.com is with a white background, and not looking great:
Whereas on dune.com it's the nice transparent one:
I've updated the favicon with the one from the logo pack at https://community.dune.com/brand#logo-section ; now I'm...
Handing this over to you for review @dericksozo 👍
Note
Replaces
Dune_Favicon.svgwith a new 1200×1200 SVG using updated paths, colors, and clipPath grouping.Dune_Favicon.svgwith new artwork:126x126→1200x1200and updatedviewBox.<g clip-path>and<defs>/<clipPath>structure.#171717→#0F0F15).Written by Cursor Bugbot for commit 2551f7e. Configure here.