-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dark theme palette #265
Comments
I agree in regard to the editor toolbar in dark mode. The trouble is, these icons (and their colour) are all part of a single image (see here). If you fancy playing around with the colours in this image (ideally sticking to the theme colours) then I could swap it out. |
@dullage I tried some workarounds, but since the icons do not accept color, even darker shades do not show much contrast. Here are some options we have. Since you insist on not modifying the palette, the final one is impractical. This tool is useful if you're planning to update palette for dark mode https://colorffy.com/dark-theme-generator |
There's a dark theme example from toast-ui devs here: https://nhn.github.io/tui.editor/latest/tutorial-example06-dark-theme displaying a toolbar with bright icons At a quick glance I see they're setting a |
Thanks @Code-Otto. Looking at their example made me realise that I wasn't using their dark mode icons! I thought I was but a number of versions ago I changed from using a |
The overall color scheme looks great.
The editor's color scheme is unappealing in dark mode! Possibly because the text color blends too much with the background. And the toolbar visibility is unusually transparent; this could be due to inadequate support for dark mode in the editor library used, but I'm not sure.
If you don't want to waste your time on this, I'd be happy to raise a PR.
The text was updated successfully, but these errors were encountered: