Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dark theme palette #265

Open
shinjith-dev opened this issue Dec 2, 2024 · 4 comments
Open

Update dark theme palette #265

shinjith-dev opened this issue Dec 2, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@shinjith-dev
Copy link

shinjith-dev commented Dec 2, 2024

The overall color scheme looks great.

The editor's color scheme is unappealing in dark mode! Possibly because the text color blends too much with the background. And the toolbar visibility is unusually transparent; this could be due to inadequate support for dark mode in the editor library used, but I'm not sure.

If you don't want to waste your time on this, I'd be happy to raise a PR.

@dullage
Copy link
Owner

dullage commented Dec 3, 2024

I agree in regard to the editor toolbar in dark mode. The trouble is, these icons (and their colour) are all part of a single image (see here). If you fancy playing around with the colours in this image (ideally sticking to the theme colours) then I could swap it out.

@dullage dullage added the suggestion An enhancement that may be considered in the future label Dec 3, 2024
@shinjith-dev
Copy link
Author

@dullage I tried some workarounds, but since the icons do not accept color, even darker shades do not show much contrast. Here are some options we have. Since you insist on not modifying the palette, the final one is impractical.

(orginal)
Firefox_Screenshot_2024-12-03T14-05-33 152Z

Firefox_Screenshot_2024-12-03T14-00-04 679Z

Firefox_Screenshot_2024-12-03T14-04-53 938Z

Firefox_Screenshot_2024-12-03T14-11-45 353Z

This tool is useful if you're planning to update palette for dark mode https://colorffy.com/dark-theme-generator

@Code-Otto
Copy link
Contributor

There's a dark theme example from toast-ui devs here: https://nhn.github.io/tui.editor/latest/tutorial-example06-dark-theme displaying a toolbar with bright icons

At a quick glance I see they're setting a theme: 'dark' attribute at the Editor object's constructor

@dullage
Copy link
Owner

dullage commented Dec 10, 2024

Thanks @Code-Otto. Looking at their example made me realise that I wasn't using their dark mode icons! I thought I was but a number of versions ago I changed from using a .dark-theme class to a .dark one and had missed a few cases (including these buttons!).

I've pushed a fix, and it looks like this now:
image

@dullage dullage added bug Something isn't working and removed suggestion An enhancement that may be considered in the future labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants