docs(readme): update README to include the minimum node.js version #726
Conversation
This is a work-around to stop the rate limit issue when publishing. You can check the issue here semantic-release/semantic-release#2204
| [ | ||
| "@semantic-release/github", | ||
| { | ||
| "successComment": false, | ||
| "failTitle": false | ||
| } | ||
| ] |
There was a problem hiding this comment.
This seems unrelated – what's the background here?
There was a problem hiding this comment.
Yeah, sorry I should have mentioned this on the description (which I will add). This is because of this: https://github.com/duffelhq/duffel-api-javascript/actions/runs/4881478277/jobs/8710431028
There was a problem hiding this comment.
Ah thanks for the context. I'm still a bit confused though – the thing you linked to mentions that we've hit a rate limiting issue?
There was a problem hiding this comment.
Yes, indeed. This is because every time we publish a new release we comment on GH issues which causes our workflow to fail if rate limited by GH. Please see semantic-release/semantic-release#2204 for further informations on the work-around and issue
There was a problem hiding this comment.
Ah I see – thanks! It's a shame we can't add comments to package.json to give more context, but we can always check the git blame for it in the future and find this PR at least
On the previous PR, we missed updating the README to reflect the new Node.js engine.
➕ Extra change:
We were rate limited on GitHub API which caused our workflow to fail, this is due to an issue with semantic-release. I've disabled comments on issues to prevent this from happening.