🐛 fix duplicate extensions

Author: dudeofawesome

packages/create-configs/src/steps/scripts.spec.ts

@@ -3,14 +3,32 @@ import { _generate_lint_script } from './scripts.js';
 
 describe('scripts', () => {
   describe(_generate_lint_script.name, () => {
-    it(`should create lint scripts`, () => {
+    it(`should create ts lint scripts`, () => {
       const output = _generate_lint_script({
         builder: 'esbuild',
         languages: ['ts'],
         technologies: ['react'],
       });
       expect(output.lint).toMatch(/concurrently.+"npm:lint:\*"/u);
-      expect(output['lint:js']).toMatch(/^eslint/u);
+      expect(output['lint:js']).toMatch(/^eslint /u);
+      expect(output['lint:js']).toMatch(/ --ext /u);
+      expect(
+        output['lint:js']?.match(/--ext (\S+)\b/u)?.[1]?.split(','),
+      ).toEqual(['ts', 'tsx', 'json']);
+    });
+
+    it(`should create ts & js lint scripts`, () => {
+      const output = _generate_lint_script({
+        builder: 'esbuild',
+        languages: ['ts', 'js'],
+        technologies: [],
+      });
+      expect(output.lint).toMatch(/concurrently.+"npm:lint:\*"/u);
+      expect(output['lint:js']).toMatch(/^eslint /u);
+      expect(output['lint:js']).toMatch(/ --ext /u);
+      expect(
+        output['lint:js']?.match(/--ext (\S+)\b/u)?.[1]?.split(','),
+      ).toEqual(['js', 'ts', 'json']);
     });
   });
 });

packages/create-configs/src/steps/scripts.ts

@@ -91,15 +91,14 @@ export function _generate_lint_script({
             ...scripts,
             'lint:js': `eslint . --ext ${languages
               .filter((l) => ['js', 'ts'].includes(l))
-              .reduce<string[]>((extensions, ext) => {
-                return [
+              .reduce<string[]>(
+                (extensions, ext) => [
+                  ext,
+                  ...(technologies.includes('react') ? [`${ext}x`] : []),
                   ...extensions,
-                  ...(technologies.includes('react')
-                    ? [ext]
-                    : [ext, `${ext}x`]),
-                  'json',
-                ];
-              }, [])
+                ],
+                ['json'],
+              )
               .join(',')} --cache`,
           };
         case 'stylelint':