Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Chat support widget" category #242

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Add "Chat support widget" category #242

merged 4 commits into from
Jan 5, 2024

Conversation

sammacbeth
Copy link
Contributor

  • Adds the "Chat support widget" category to categorized_trackers.csv.
  • Adds an initial list of domains to that category.
  • Fixes some data issues in the existing list (removed duplicate entries, sorted entries by domain).
  • Adds a script to allow for simplied modification of this list by shipping the list to sqlite and then back again. This allows us to prevent constraint violations (no duplicate domains), and enables upserts when adding new domains.

Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dharb dharb merged commit 3666b43 into main Jan 5, 2024
2 checks passed
@dharb dharb deleted the sam/update-categories branch January 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants