Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to email incontext behaviour when multiple windows are open #1455

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Aug 9, 2023

Task/Issue URL: https://app.asana.com/0/1198964220583541/1205223894381359/f
Tech Design URL:
CC:

Description:
Fixes issues around InContext signup triggering notification listeners in multiple windows causing unexpected behaviours when signing up / in

Steps to test this PR:

  1. Make sure you are signed out of Email Protection and if necessary "Reset Email Protection InContext Signup Prompt" in the Debug menu
  2. Open multiple windows with one or more tabs open in each window
  3. In one window visit https://fill.dev/form/registration-email
  4. Tap the grey dax icon and follow the sign-up flow. Confirm the sign-up tab url loads correctly and is only opened in the current window
  5. On completing sign-up, confirm you are taken back to your tab https://fill.dev/form/registration-email and that the autofill email tooltip is presented on the email field
  6. Repeat steps 1-5 testing sign-in flow is also good

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy changed the base branch from develop to main December 6, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant