Remove malformed error pixel (#3612)

Task/Issue URL: https://app.asana.com/0/414235014887631/1208683003138954/f
Tech Design URL:
CC:

Description:

This PR removes the malformed error pixel.

Author: samsymons

DuckDuckGo.xcodeproj/project.pbxproj

@@ -15347,7 +15347,7 @@
 			repositoryURL = "https://github.com/duckduckgo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 215.0.1;
+				version = 216.0.0;
 			};
 		};
 		9FF521422BAA8FF300B9819B /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -113,8 +113,6 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
     case networkProtectionConfigurationErrorLoadingCachedConfig(_ error: Error)
     case networkProtectionConfigurationFailedToParse(_ error: Error)
 
-    case networkProtectionMalformedErrorDetected(_ error: Error)
-
     case networkProtectionUnhandledError(function: String, line: Int, error: Error)
 
     /// Name of the pixel event
@@ -330,9 +328,6 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
         case .networkProtectionConfigurationFailedToParse:
             return "netp_ev_configuration_failed_to_parse"
 
-        case .networkProtectionMalformedErrorDetected:
-            return "netp_malformed_error_detected"
-
         case .networkProtectionUnhandledError:
             return "netp_unhandled_error"
         }
@@ -445,8 +440,7 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
                 .networkProtectionServerMigrationSuccess,
                 .networkProtectionDNSUpdateCustom,
                 .networkProtectionDNSUpdateDefault,
-                .networkProtectionConfigurationInvalidPayload,
-                .networkProtectionMalformedErrorDetected:
+                .networkProtectionConfigurationInvalidPayload:
             return nil
         }
     }
@@ -473,8 +467,7 @@ enum NetworkProtectionPixelEvent: PixelKitEventV2 {
                 .networkProtectionSystemExtensionActivationFailure(let error),
                 .networkProtectionServerMigrationFailure(let error),
                 .networkProtectionConfigurationErrorLoadingCachedConfig(let error),
-                .networkProtectionConfigurationFailedToParse(let error),
-                .networkProtectionMalformedErrorDetected(let error):
+                .networkProtectionConfigurationFailedToParse(let error):
             return error
         case .networkProtectionActiveUser,
                 .networkProtectionNewUser,

DuckDuckGo/NetworkProtection/AppAndExtensionAndAgentTargets/NetworkProtectionPixelEvent.swift

@@ -390,11 +390,6 @@ final class MacPacketTunnelProvider: PacketTunnelProvider {
                 NetworkProtectionPixelEvent.networkProtectionTunnelStartAttemptOnDemandWithoutAccessToken,
                 frequency: .legacyDailyAndCount,
                 includeAppVersionParameter: true)
-        case .malformedErrorDetected(let error):
-            PixelKit.fire(
-                NetworkProtectionPixelEvent.networkProtectionMalformedErrorDetected(error),
-                frequency: .legacyDailyAndCount,
-                includeAppVersionParameter: true)
         }
     }
 

DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift

@@ -29,7 +29,7 @@ let package = Package(
             targets: ["DataBrokerProtection"])
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "215.0.1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "216.0.0"),
         .package(path: "../SwiftUIExtensions"),
         .package(path: "../AppKitExtensions"),
         .package(path: "../XPCHelper"),

LocalPackages/DataBrokerProtection/Package.swift

@@ -32,7 +32,7 @@ let package = Package(
             targets: ["FeatureFlags"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "215.0.1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "216.0.0"),
     ],
     targets: [
         // Targets are the basic building blocks of a package, defining a module or a test suite.

LocalPackages/FeatureFlags/Package.swift

@@ -32,7 +32,7 @@ let package = Package(
         .library(name: "VPNAppLauncher", targets: ["VPNAppLauncher"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "215.0.1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "216.0.0"),
         .package(url: "https://github.com/airbnb/lottie-spm", exact: "4.4.3"),
         .package(path: "../AppLauncher"),
         .package(path: "../UDSHelper"),

LocalPackages/NetworkProtectionMac/Package.swift

@@ -12,7 +12,7 @@ let package = Package(
             targets: ["SubscriptionUI"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "215.0.1"),
+        .package(url: "https://github.com/duckduckgo/BrowserServicesKit", exact: "216.0.0"),
         .package(path: "../SwiftUIExtensions"),
         .package(path: "../FeatureFlags")
     ],