Update Settings: Update sub-screens #5334
Open
+769
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new "Learn More" link text does not have an underline and is our own blue color We need to ensure that "Learn More" is placed on a newline after we create the Spannable The Cookie Image is slightly different in on/off scenarios (spikey cookie ends, checkmark sizing) and I will ask about this
We have one more state "Always On" which we need for a couple of sub screens. It makes more sense now to add this as an emum and allow setting from XML We can make a function that allows us to easily set on/off which we need in most cases that calls to the new setStatus function that takes a "Status"
It seemed easiest to add new views and just hide/show based on the flag
Similar to AutoConsent and I've made a note to extract the clickable span when I come back to tidy up
I purposefully did not flag the minor margin changes for the divider, I didn't think it was worth it.
Again not flagging purposefully as it's such a minor change
not flagging this as it's a simple change
This was referenced Nov 29, 2024
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
36 tasks
We don't need to use makeSceneTransitionAnimation as we're not doing SharedElementTransitions This looks like it became a c/p for all the screens, resulting in some weird cross-fading
mikescamell
force-pushed
the
feature/mike/update-settings/update_subscreens
branch
from
d5d90b7
to
9cbd91e
Compare
mikescamell
force-pushed
the
feature/mike/update-settings/update_subscreens
branch
from
9cbd91e
to
a3873ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1207908166761516/1208785622935234/f
Description
Makes design changes to all the settings sub-screens, including:
Steps to test this PR
Prerequisites:
newSettingsflag is onDesigns:
Private Search
UI changes
Web Tracking Protection
UI changes
Cookie Pop-Up Protection
UI changes
App Tracking Protection
Email Protection
General
Sync & Backup
UI changes
Appearance
UI changes
Passwords & Autofill
UI changes
Accessibility
UI changes
Permissions
Data Clearing
UI changes
Duck Player
About
UI changes
LegacySettings Screen
Prerequisites:
newSettingsflag is offDemo
Screen_recording_20241129_163452.mp4