-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Settings: Rearrange Settings screen #5330
Open
mikescamell
wants to merge
19
commits into
feature/mike/update-settings/add-new-setting-list-item
Choose a base branch
from
feature/mike/update-settings/rearrange-settings-screen
base: feature/mike/update-settings/add-new-setting-list-item
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update Settings: Rearrange Settings screen #5330
mikescamell
wants to merge
19
commits into
feature/mike/update-settings/add-new-setting-list-item
from
feature/mike/update-settings/rearrange-settings-screen
+374
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
42 tasks
mikescamell
force-pushed
the
feature/mike/update-settings/rearrange-settings-screen
branch
2 times, most recently
from
November 28, 2024 10:14
eda06ff
to
9bd1d55
Compare
a lift and shift from the about screen I will follow up and ask about whether we need to change the pixel name for share feedback considering it will no longer be in the about screen
We had duplicate ic_open_in_24 so I deleted the one in vpn and moved it to common-ui I'll need it here later for the plugins work
We just open the browser on duckduckgo.com/app page which lists our other platforms
It's now very obvious if you're on the new screen
mikescamell
force-pushed
the
feature/mike/update-settings/add-new-setting-list-item
branch
from
November 29, 2024 12:28
0782d10
to
d8f02fd
Compare
mikescamell
force-pushed
the
feature/mike/update-settings/rearrange-settings-screen
branch
from
November 29, 2024 12:28
9bd1d55
to
b062abb
Compare
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1208785622935238/f
Description
Rearranges the new Settings screen:
Steps to test this PR
Pre-requisites: Enabled
newSettings
feature flagTitles
Main Settings Order
Next Steps
Pre-requisite: Non-Pixel device
Next Steps Voice Search
Pre-requisite: Pixel device
Other section
DuckPlayer icon
Pre-requisites: Disable
newSettings
feature flagUI changes
Demo