Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Settings: Rearrange Settings screen #5330

Open
wants to merge 19 commits into
base: feature/mike/update-settings/add-new-setting-list-item
Choose a base branch
from

Conversation

mikescamell
Copy link
Contributor

@mikescamell mikescamell commented Nov 28, 2024

Task/Issue URL: https://app.asana.com/0/0/1208785622935238/f

Description

Rearranges the new Settings screen:

  • All items are renamed and have icons added where appropriate
  • New Next Steps section added
  • Other section now contains Share Feedback and Other Platforms item
  • Ppro section is not updated as part of this work, it will be done at a later stage once the API is ready to detect the correct status

Steps to test this PR

Pre-requisites: Enabled newSettings feature flag

Titles

  • Open Settings
  • Check title in Toolbar is back "Settings"
  • Check first section title is "Privacy Protections"
  • Check second section title is "Main Settings"
  • Check third section title is "Next Steps"
  • Check fourth section has no title

Main Settings Order

  • Open Settings
  • Check the order of Main Settings against designs
  • Click each option and check the correct screen opens

Next Steps

Pre-requisite: Non-Pixel device

  • Open Settings
  • Check the order of Next Steps against designs
  • "Enable Voice Search" should not be visible
  • Click "Add Widget to Homescreen"
  • Widget BottomSheet should open
  • Dismiss
  • Click "Set Your Address Bar Position"
  • Appearance screen should open

Next Steps Voice Search

Pre-requisite: Pixel device

  • Open Settings
  • Check the order of Next Steps against designs
  • "Enable Voice Search" should be visible
  • Click "Enable Voice Search"
  • The Accessibility screen should open

Other section

  • Open Settings
  • Check the order of the other section against designs
  • Click "About" item
  • About screen should open
  • Scroll to the bottom and check "Share Feedback" is not visible
  • Press back
  • Click "Share Feedback"
  • Submit some feedback
  • A Snackbar should pop on the Settings screen thanking for feedback
  • Click "DuckDuckGo on Other Platforms"
  • Browser screen should open on "duckduckgo.com/app"

DuckPlayer icon

Pre-requisites: Disable newSettings feature flag

  • Open Settings
  • Find Duck Player
  • There should not be an leading icon

UI changes

Before After
Screenshot_20241128_105425 Screenshot_20241128_105344
Screenshot_20241128_105432 Screenshot_20241128_105326

Demo

🎥 Video uploaded on Graphite:

Copy link
Contributor Author

mikescamell commented Nov 28, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mikescamell mikescamell force-pushed the feature/mike/update-settings/rearrange-settings-screen branch 2 times, most recently from eda06ff to 9bd1d55 Compare November 28, 2024 10:14
@mikescamell mikescamell marked this pull request as ready for review November 28, 2024 10:58
a lift and shift from the about screen

I will follow up and ask about whether we need to change the pixel name for share feedback considering it will no longer be in the about screen
We had duplicate ic_open_in_24 so I deleted the one in vpn and moved it to common-ui

I'll need it here later for the plugins work
We just open the browser on duckduckgo.com/app page which lists our other platforms
It's now very obvious if you're on the new screen
@mikescamell mikescamell force-pushed the feature/mike/update-settings/add-new-setting-list-item branch from 0782d10 to d8f02fd Compare November 29, 2024 12:28
@mikescamell mikescamell force-pushed the feature/mike/update-settings/rearrange-settings-screen branch from 9bd1d55 to b062abb Compare November 29, 2024 12:28
@malmstein malmstein self-assigned this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants