Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Settings design: Add new SettingsListItem #5318

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Update Settings design: Add new SettingsListItem #5318

wants to merge 7 commits into from
+1,256 −49

Commits on Nov 29, 2024

  1. duplicating content settings and privacy

    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    68420c6 View commit details
    Browse the repository at this point in the history

  2. add new icons

    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    6b40e08 View commit details
    Browse the repository at this point in the history

  3. add new SettingsListItem

    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    797440d View commit details
    Browse the repository at this point in the history

  4. switch to SettingsListItem in privacy section 

    Also adding all the new icons, removing secondary text and itemState, and adding the new isOn for search and web tracking settings

Next commit we'll ensure the indicators are on/off
    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    7799cb0 View commit details
    Browse the repository at this point in the history

  5. set items to on/off based on state 

    I've removed appTrackingProtectionOnboardingShown state as only have 2 states now, on/off, but I will follow up and ask Thomas if this is expected
    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    fac2d06 View commit details
    Browse the repository at this point in the history

  6. add SettingsListItem to ADS 

    I think this is worth having on the ADS screen, even if not officially a component. Happy to move it if needs be.
    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    f475c87 View commit details
    Browse the repository at this point in the history

  7. formatting

    @mikescamell
    mikescamell committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    d8f02fd View commit details
    Browse the repository at this point in the history