Enable windows_arm64 arch for main extensions #20004
Conversation
|
Filed duckdb/duckdb-spatial/pull/720 to fix that. |
Updating Spatial to include duckdb/duckdb-spatial#720 that is necessary for #20004.
This change adds `opt_in_archs` argument to the `Extensions.yml` workflow and passes it down to `_extension_distribution.yml`. The default value is set to `windows_arm64;` with the intention to keep it there (if it will work correctly and will not cause problems) to have Windows ARM64 extension builds enabled by default. This change only enables it for Main extensions. Rust-based extensions (`delta`) can be added later - it requires Python wheel re-build (for `configure` step, until `windows_arm64` binary wheel is available). It works on CI, but takes additional 35 mins.
staticlibs
force-pushed
the
win_arm64_extensions
branch
from
b9aa38d to
15a69a2
Compare
|
#20020 was merged, I rebased the changes onto the latest 1.4, moving to ready to review to re-run the CI. |
pdet
requested review from
carlopi and
samansmink
and removed request for
samansmink
|
Added a commit removing Also moved the opt-in value I believe the PR is ready to be reviewed for integration now. |
carlopi
left a comment
carlopi
left a comment
There was a problem hiding this comment.
LGTM!
Given he followed the other stream of PRs, I think a second look from @samansmink could be handy.
Fix mark join decorrelation (duckdb/duckdb#20033) Enable windows_arm64 arch for main extensions (duckdb/duckdb#20004)
Fix mark join decorrelation (duckdb/duckdb#20033) Enable windows_arm64 arch for main extensions (duckdb/duckdb#20004) Co-authored-by: krlmlr <[email protected]>
4 participants
This change adds
opt_in_archsargument to theExtensions.ymlworkflow and passes it down to_extension_distribution.yml.The default value is set to
windows_arm64;with the intention to keep it there (if it will work correctly and will not cause problems) to have Windows ARM64 extension builds enabled by default.This change only enables it for Main extensions. Rust-based extensions (
delta) can be added later - it requires Python wheel re-build (forconfigurestep, untilwindows_arm64binary wheel is available). It works on CI, but takes additional 35 mins.