From 7e2b9b84234076273f72a6246a4aa879c4463476 Mon Sep 17 00:00:00 2001 From: Yorick Kuijs Date: Wed, 7 Apr 2021 14:02:59 +0200 Subject: [PATCH] Fixed review comments --- .../MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1 | 4 ++-- .../SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1 | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/SharePointDsc/DSCResources/MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1 b/SharePointDsc/DSCResources/MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1 index 6ad905946..8ac845275 100644 --- a/SharePointDsc/DSCResources/MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1 +++ b/SharePointDsc/DSCResources/MSFT_SPUsageDefinition/MSFT_SPUsageDefinition.psm1 @@ -49,7 +49,7 @@ function Get-TargetResource -ScriptBlock { $params = $args[0] - $usageDefinition = Get-SPUsageDefinition | Where-Object { $_.Name -eq $params.Name } + $usageDefinition = Get-SPUsageDefinition -Identity $params.Name $nullReturn = @{ Name = $params.Name DaysRetained = $params.DaysRetained @@ -162,7 +162,7 @@ function Set-TargetResource $params = $args[0] $eventSource = $args[1] - $usageDefinition = Get-SPUsageDefinition | Where-Object { $_.Name -eq $params.Name } + $usageDefinition = Get-SPUsageDefinition -Identity $params.Name if ($null -eq $usageDefinition) { diff --git a/tests/Unit/SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1 b/tests/Unit/SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1 index 68d149b19..e01062c9b 100644 --- a/tests/Unit/SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1 +++ b/tests/Unit/SharePointDsc/SharePointDsc.SPUsageDefinition.Tests.ps1 @@ -102,6 +102,8 @@ try { $testParams.UsageDatabaseEnabled = $true } + + Mock -CommandName Get-SPUsageDefinition -MockWith { return $null } } It "Should return false when the Test method is called" {