Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraArgs (passed in on the cli) should contribute toward the cache key #60

Open
ds300 opened this issue Apr 19, 2023 · 0 comments
Open

Comments

@ds300
Copy link
Owner

ds300 commented Apr 19, 2023

If i run lazy test -- foo and it succeeds then it should not necessarily succeed when I run lazy test -- bar.

We should stringify the extraArgs and add them to the manifest in computeManifest.js. We'll need to add another manifest 'type' too

const types = {
upstreamTaskInputs: 'upstream task inputs',
dependencyTaskInputs: 'dependency task inputs',
envVar: 'env var',
file: 'file',
}

@ds300 ds300 converted this from a draft issue Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔖 Ready
Development

No branches or pull requests

1 participant