Issue #2910796 by bartlangelaan: Cache should be optional

Author: bartlangelaan

config/install/hn.settings.yml

@@ -0,0 +1 @@
+cache: true

config/schema/hn.schema.yml

@@ -0,0 +1,7 @@
+hn.settings:
+  type: config_object
+  label: 'HN Settings'
+  mapping:
+    cache:
+      type: boolean
+      label: 'Caching'

hn.install

@@ -0,0 +1,20 @@
+<?php
+
+/**
+ * @file
+ * This file provides updates for the HN module.
+ */
+
+/**
+ * Uninstall hn_extended_view_serializer.
+ */
+function hn_update_8001() {
+  \Drupal::service('module_installer')->uninstall(['hn_extended_view_serializer']);
+}
+
+/**
+ * Add config file with cache enabled.
+ */
+function hn_update_8002() {
+  \Drupal::configFactory()->getEditable('hn.settings')->set('cache', TRUE)->save();
+}

hn.module

@@ -8,7 +8,6 @@
 use Drupal\hn\Event\HnEntityEvent;
 use Drupal\hn\Event\HnHandledEntityEvent;
 use Drupal\hn\Event\HnResponseEvent;
-use Drupal\node\Entity\Node;
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
@@ -35,7 +34,7 @@ class HnResponseService {
    */
   protected $currentUser;
   /**
-   * Drupal\webprofiler\Config\ConfigFactoryWrapper definition.
+   * Drupal\Core\Config\ConfigFactory definition.
    *
    * @var \Drupal\Core\Config\ConfigFactory
    */
@@ -93,6 +92,8 @@ private function alterResponse($eventName) {
    */
   public function getResponseData() {
 
+    $config = $this->config->get('hn.settings');
+
     // First, get the current request.
     $r = \Drupal::request();
 
@@ -135,7 +136,7 @@ public function getResponseData() {
     }
 
     // Check if this page is cached.
-    if (!$this->debugging && $cache = $this->cache->get('hn.response_cache.' . $path)) {
+    if ($config->get('cache') && !$this->debugging && $cache = $this->cache->get('hn.response_cache.' . $path)) {
       $this->responseData = $cache->data;
     }
 
@@ -150,7 +151,9 @@ public function getResponseData() {
         }
       }
 
-      \Drupal::cache()->set('hn.response_cache.' . $path, $this->responseData, Cache::PERMANENT, $cache_tags);
+      if ($config->get('cache')) {
+        \Drupal::cache()->set('hn.response_cache.' . $path, $this->responseData, Cache::PERMANENT, $cache_tags);
+      }
     }
 
     $this->alterResponse(HnResponseEvent::PRE_SEND);