Issue #2923656 by czigor, kiwimind, opdavies, utement: Unable to use cart with new configuration

Author: czigor

modules/order/commerce_order.module

@@ -140,7 +140,7 @@ function commerce_order_add_order_items_field(OrderTypeInterface $order_type) {
     ->setLabel('Order items')
     ->setCardinality(BundleFieldDefinition::CARDINALITY_UNLIMITED)
     ->setRequired(TRUE)
-    ->setSetting('target_type', 'commerce_order_type')
+    ->setSetting('target_type', 'commerce_order_item')
     ->setSetting('handler', 'default')
     ->setDisplayOptions('form', [
       'type' => 'inline_entity_form_complex',

modules/order/tests/src/Functional/OrderTypeTest.php

@@ -26,6 +26,10 @@ public function testDefaultOrderType() {
    * Tests creating an order Type programaticaly and through the add form.
    */
   public function testCreateOrderType() {
+    // Remove the default order type to be able to test creating the
+    // order_items field anew.
+    OrderType::load('default')->delete();
+
     // Create an order type programmaticaly.
     $type = $this->createEntity('commerce_order_type', [
       'id' => 'kitten',
@@ -48,6 +52,10 @@ public function testCreateOrderType() {
 
     $type_exists = (bool) OrderType::load($values['id']);
     $this->assertNotEmpty($type_exists, 'The new order type has been created in the database.');
+
+    // Testing the target type of the order_items field.
+    $settings = $this->config('field.storage.commerce_order.order_items')->get('settings');
+    $this->assertEquals('commerce_order_item', $settings['target_type'], t('Order item field target type is correct.'));
   }
 
   /**
@@ -69,7 +77,7 @@ public function testDraftOrderRefreshSettings() {
   }
 
   /**
-   * Tests deleting an order Type programmaticaly and through the form.
+   * Tests deleting an order Type through the form.
    */
   public function testDeleteOrderType() {
     // Create an order type programmaticaly.