Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DDL().execute_if(dialect='...') has incorrect type definition #181

Open
jace opened this issue Oct 21, 2020 · 0 comments · May be fixed by #219
Open

DDL().execute_if(dialect='...') has incorrect type definition #181

jace opened this issue Oct 21, 2020 · 0 comments · May be fixed by #219

Comments

@jace
Copy link

jace commented Oct 21, 2020

mypy raised an error on this code:

DDL(stmt).execute_if(dialect='postgresql')

error: Argument "dialect" to "execute_if" of "DDLElement" has incompatible type "str"; expected "Optional[Dialect]"

However, the documentation for this method and source code suggest that the expected type is:

Optional[Union[str, Tuple[str, ...], List[str], Set[str]]].

Location of problem:

sqlalchemy-stubs/sqlalchemy-stubs/sql/ddl.pyi

Line 36 in 55470ce

def execute_if(self: _DDLE, dialect: Optional[Dialect] = ..., callable_: Optional[_DDLCallable] = ...,

philpep added a commit to philpep/sqlalchemy-stubs that referenced this issue Jun 11, 2021
@philpep
Fix sqlalchemy.ddl.DDL.execute_if dialect type (dropbox#181)
578a48a 
dialect should be a string a list/tuple/set of strings. Not a Dialect
object.

https://github.com/sqlalchemy/sqlalchemy/blob/rel_1_4_18/lib/sqlalchemy/sql/ddl.py#L158

Closes dropbox#181
@philpep philpep linked a pull request Jun 11, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sqlalchemy.ddl.DDL.execute_if dialect type (#181) philpep/sqlalchemy-stubs
1 participant
@jace