Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow akashi compare to take multiple rulesets #15

Open
ryan-ph opened this issue Apr 16, 2024 · 0 comments
Open

Allow akashi compare to take multiple rulesets #15

ryan-ph opened this issue Apr 16, 2024 · 0 comments

Comments

@ryan-ph
Copy link
Contributor

ryan-ph commented Apr 16, 2024

Why

Generally Akashi rulesets are written to contain expected changes from vN to v{N + 1}. However, in some cases, users will be incrementing their module versions by more than one (e.g. incrementing from v0.38.5 to v0.38.9).

In this case, akashi compare should still be able to validate the changes produced by this version bump only contains the changes specified in the rulesets for v0.38.{6..9}.

Proposal

Update akashi compare to take at least 1 ruleset. The CLI would then work like:

# Same as current behavior
akashi compare path/to/version1.yaml 
akashi compare  # error! no ruleset provided

# Take multiple rulesets
akashi compare path/to/version1.yaml path/to/version2.yaml

Open questions

  • How should rulesets be merged? Mainly how should we merge CompareOptions that are specified for rulesets and resource changes
  • How should we handle resources that change in multiple different rulesets that are provided to Akashi?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant