Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a bug of find/replace feature #680

Closed
yu2chuan opened this issue Jun 27, 2024 · 2 comments · Fixed by #688
Closed

a bug of find/replace feature #680

yu2chuan opened this issue Jun 27, 2024 · 2 comments · Fixed by #688
Assignees
@drl990114
Labels
bug Something isn't working

Comments

@yu2chuan
Copy link

Describe the bug
highlight the wrong term in the find/replace feature

To Reproduce

  1. Go to any md file in English
  2. Ctrl+F to trigger the find/replace feature
  3. input something to find and perform replace
  4. this feature will highlight the wrong term and replace what it was wrongly highlighted.

Expected behavior

Screenshots

Desktop (please complete the following information):

  • OS: Win 10
  • Version 0.11.3

Additional context
replacing the wrongly highlighted term will be a little bit critical.
@yu2chuan yu2chuan added the status: needs triage This issue needs to triage, applied to new issues label Jun 27, 2024
@drl990114
Copy link
Owner

I suspect it was caused by the combination of global search and single file search. If global search is not turned on and only single file search is used, is the result correct?

@yu2chuan
Copy link
Author

https://drive.google.com/file/d/19w-mqipwMuH4FxBKt68uJ_KAfBF4E6T1/view?usp=drive_link
I don't know when it could go wrong. Please check my test file in the link.

@drl990114 drl990114 added bug Something isn't working and removed status: needs triage This issue needs to triage, applied to new issues labels Jun 28, 2024
@drl990114 drl990114 mentioned this issue Jul 16, 2024
Merged
2 tasks
drl990114 added a commit to drl990114/rme that referenced this issue Jul 22, 2024
@drl990114
fix: find result error
24972aa 
drl990114/MarkFlowy#680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drl990114 drl990114

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: right bar layout drl990114/MarkFlowy
2 participants
@drl990114 @yu2chuan