where.first can be replaced by find_by

[lelelelemon]

ror_ecommerce/app/models/variant.rb

Line 189 in d4a00ef

pp = self.variant_properties.where({ :variant_properties => {:primary => true}}).first

in order to avoid the unnecessary order by primary key operation

[drhenner]

👍

Yeah I think the SQL caching is better with find_by now days. Not sure if that was the case when I originally created this method.

[lelelelemon]

And I searched for other places, seems they can also be replaced:

app/controllers/shopping/orders_controller.rb: @order = Order.where(number: params[:id]).includes({order_items: :variant}).first
app/controllers/wish_items_controller.rb: item = current_user.wish_list_items.where(variant_id: params[:variant_id]).first
app/models/users_newsletter.rb: user = User.where(email: email).first
app/models/cart.rb: variant = Variant.where(id: variant_id).first