Update all dependencies (major) (#396)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Alex Skrypnyk <[email protected]>

Author: renovate[bot]

composer.json

@@ -33,14 +33,14 @@
         "drupal/coder": "^8.3.28",
         "dvdoug/behat-code-coverage": "^5.3.2.1",
         "ergebnis/composer-normalize": "^2.47",
-        "mglaman/phpstan-drupal": "^1.3.7",
+        "mglaman/phpstan-drupal": "^2.0.0",
         "php-parallel-lint/php-parallel-lint": "^1.4",
         "phpcompatibility/php-compatibility": "^9.3.5",
         "phpspec/prophecy-phpunit": "^2.3",
         "phpstan/extension-installer": "^1.4.3",
-        "phpstan/phpstan": "^1.12.25",
+        "phpstan/phpstan": "^2.0.0",
         "phpunit/phpunit": "^11",
-        "rector/rector": "^1.2"
+        "rector/rector": "^2.0"
     },
     "autoload": {
         "psr-4": {

docker-compose.yml

@@ -69,7 +69,7 @@ services:
       - "3306"
 
   chrome:
-    image: selenium/standalone-chromium:135.0
+    image: selenium/standalone-chromium:136.0
     ports:
       - "7900:7900" # Access Chrome using noVNC at http://behat-steps.docker.amazee.io:7900/?autoconnect=1&password=secret
     expose:

docs.php

@@ -241,9 +241,8 @@ function parse_class_comment(string $trait_name, string $comment): array {
   }
 
   $comment = preg_replace('#^/\*\*|^\s*\*\/$#m', '', $comment);
-  $lines = array_values(
-    array_map(static fn($l): string => ltrim($l, " *\t"), explode(PHP_EOL, (string) $comment))
-  );
+  $lines = explode(PHP_EOL, (string) $comment);
+  $lines = array_map(static fn($l): string => ltrim($l, " *\t"), $lines);
 
   // Remove first and last empty lines.
   if (count($lines) > 1 && empty($lines[0])) {

phpstan.neon

@@ -18,6 +18,7 @@ parameters:
     - vendor/*
     - node_modules/*
     - tests/behat/bootstrap/BehatCliContext.php
+    - tests/behat/bootstrap/BehatCliTrait.php
 
   scanFiles:
     - vendor/behat/behat/bin/behat
@@ -40,3 +41,6 @@ parameters:
         - '#.*Cannot call method.*getCurrentUrl\(\).*#'
       paths:
         - tests/phpunit/*
+
+    # @see https://github.com/mglaman/phpstan-drupal/issues/825
+    - '#Call to method Drupal\\Core\\Entity\\Query\\QueryInterface::accessCheck\(\) with false will always evaluate to true.#'

src/Drupal/ContentTrait.php

@@ -169,7 +169,6 @@ public function contentChangeModerationStateWithTitle(string $content_type, stri
     ksort($nids);
 
     $nid = end($nids);
-    /** @var \Drupal\node\Entity\Node $node */
     $node = Node::load($nid);
 
     if (!$node instanceof NodeInterface) {

src/Drupal/FileTrait.php

@@ -106,7 +106,7 @@ protected function fileCreateEntity(\StdClass $stub): FileInterface {
       throw new \RuntimeException('"path" property is required');
     }
 
-    $path = ltrim($stub->path, '/');
+    $path = ltrim((string) $stub->path, '/');
 
     // Get fixture file path.
     if (!empty($this->getMinkParameter('files_path'))) {
@@ -123,7 +123,7 @@ protected function fileCreateEntity(\StdClass $stub): FileInterface {
     $destination = 'public://' . basename($path);
     if (!empty($stub->uri)) {
       $destination = $stub->uri;
-      $directory = dirname($destination);
+      $directory = dirname((string) $destination);
       $dir = \Drupal::service('file_system')->prepareDirectory($directory, FileSystemInterface::CREATE_DIRECTORY + FileSystemInterface::MODIFY_PERMISSIONS);
       if (!$dir) {
         throw new \RuntimeException('Unable to prepare directory ' . $directory);

src/KeyboardTrait.php

@@ -125,40 +125,38 @@ public function keyboardPressKeyOnElementSingle(string $char, ?string $selector)
     ];
 
     // Convert provided character sequence to special keys.
-    if (is_string($char)) {
-      if (strlen($char) < 1) {
-        throw new \Exception('keyPress($char) was invoked but the $char parameter was empty.');
+    if (strlen($char) < 1) {
+      throw new \Exception('keyPress($char) was invoked but the $char parameter was empty.');
+    }
+    // Consider provided characters string longer then 1 to be a keyboard key.
+    elseif (strlen($char) > 1) {
+      if (!array_key_exists(strtolower($char), $keys)) {
+        throw new \RuntimeException(sprintf('Unsupported key "%s" provided', $char));
       }
-      // Consider provided characters string longer then 1 to be a keyboard key.
-      elseif (strlen($char) > 1) {
-        if (!array_key_exists(strtolower($char), $keys)) {
-          throw new \RuntimeException(sprintf('Unsupported key "%s" provided', $char));
-        }
-
-        // Special case for tab key triggered in window without target element
-        // focused: Syn (JS library that provides synthetic events) can tab only
-        // from another element that can receive focus, so we inject such
-        // element as a very first element after opening <body> tag. This
-        // element is visually hidden, but compatible with screen readers. Then
-        // we trigger key on this element to make sure that an element that
-        // supposed to get the very first focus from tab index actually gets it.
-        // Note that injecting element and triggering key press on it does not
-        // make it focused itself.
-        if (is_null($selector) && $char === 'tab') {
-          $selector = '#injected-focusable';
-
-          $script = <<<JS
-            (function() {
-              if (document.querySelectorAll('body #injected-focusable').length === 0) {
-                document.querySelector('body').insertAdjacentHTML('afterbegin', '<a id="injected-focusable" style="position: absolute;width: 1px;height: 1px;margin: -1px;padding: 0;overflow: hidden;clip: rect(0,0,0,0);border: 0;"></a>');
-              }
-            })();
-          JS;
-          $this->getSession()->getDriver()->evaluateScript($script);
-        }
-
-        $char = $keys[strtolower($char)];
+
+      // Special case for tab key triggered in window without target element
+      // focused: Syn (JS library that provides synthetic events) can tab only
+      // from another element that can receive focus, so we inject such
+      // element as a very first element after opening <body> tag. This
+      // element is visually hidden, but compatible with screen readers. Then
+      // we trigger key on this element to make sure that an element that
+      // supposed to get the very first focus from tab index actually gets it.
+      // Note that injecting element and triggering key press on it does not
+      // make it focused itself.
+      if (is_null($selector) && $char === 'tab') {
+        $selector = '#injected-focusable';
+
+        $script = <<<JS
+          (function() {
+            if (document.querySelectorAll('body #injected-focusable').length === 0) {
+              document.querySelector('body').insertAdjacentHTML('afterbegin', '<a id="injected-focusable" style="position: absolute;width: 1px;height: 1px;margin: -1px;padding: 0;overflow: hidden;clip: rect(0,0,0,0);border: 0;"></a>');
+            }
+          })();
+        JS;
+        $this->getSession()->getDriver()->evaluateScript($script);
       }
+
+      $char = $keys[strtolower($char)];
     }
 
     $selector = $selector ?: 'html';

tests/behat/bootstrap/BehatCliContext.php

@@ -35,8 +35,6 @@
  * Behat test suite context.
  *
  * @author Konstantin Kudryashov <[email protected]>
- *
- * @SuppressWarnings(PHPMD.TooManyPublicMethods)
  */
 class BehatCliContext implements Context
 {