Add extra props on associations to delete #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we need to delete some record on association, this driver use the $pullAll command. But the $pullAll requires an exact match. So, when the association has some extra properties, we need to include these properties in the pull object.
|
Thanks, Do you think you could add one test to verify this behaviour? Otherwise it might be broken again once someone else makes a pull request. Thanks. |
|
I'm not very familiar with nodeJS test again... I'll try to implement it but I need time :) |
|
:) sounds good |
dresende
added a commit
that referenced
this pull request
Dec 22, 2014
Add extra props on associations to delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we need to delete some record on association, this driver use the $pullAll command.
But the $pullAll requires an exact match.
So, when the association has some extra properties, we need to include these properties in the pull object.